8000 [Serializer] Improve perf a bit by not using a signaling exception when not needed by nicolas-grekas · Pull Request #28910 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] Improve perf a bit by not using a signaling exception when not needed #28910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2018
Merged

[Serializer] Improve perf a bit by not using a signaling exception when not needed #28910

merged 1 commit into from
Oct 18, 2018

Conversation

@nicolas-grekas
Copy link
Member
@nicolas-grekas nicolas-grekas commented Oct 17, 2018
Q A
Branch? 4.2
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

And disabling unneeded autoload calls for interface_exists checks meanwhile.

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Oct 17, 2018
@nicolas-grekas nicolas-grekas merged commit 2a2914e into symfony:master Oct 18, 2018
nicolas-grekas added a commit that referenced this pull request Oct 18, 2018
@nicolas-grekas
minor #28910 [Serializer] Improve perf a bit by not using a signaling…
bcff647 
… exception when not needed (nicolas-grekas)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[Serializer] Improve perf a bit by not using a signaling exception when not needed

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

And disabling unneeded autoload calls for interface_exists checks meanwhile.

Commits
-------

2a2914e [Serializer] Improve perf a bit by not using a signaling exception when not needed
@nicolas-grekas nicolas-grekas deleted the if-false branch October 23, 2018 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas dunglas approved these changes

@stof stof stof approved these changes

Assignees

No one assigned

Labels

Serializer Status: Reviewed

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolas-grekas @fabpot @dunglas @stof @carsonbot
0