[Locale][Stub] Fixed CS #2890
Merged
[Locale][Stub] Fixed CS #2890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| return $regExp; | ||
| return 1 == $length ? '\d{1,2}' : '\d{'.$length.'}'; |
There was a problem hiding this comment.
this should even be a strict comparison
fabpot
added a commit
that referenced
this pull request
Dec 17, 2011
Commits ------- ed353da [Locale][Stub] Fixed CS Discussion ---------- [Locale][Stub] Fixed CS Bug fix: no Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Just fixed code according to Symfony2 CS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Just fixed code according to Symfony2 CS.