[HttpKernel][Client] Set cookie fix #2889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) cookies can be stored in same line, so lets add every as standalone to be compliant with rfc6265
fabpot
added a commit
that referenced
this pull request
Dec 17, 2011
Commits ------- 5c41ec9 [HttpKernel][Client] Only simple (name=value without any other params) cookies can be stored in same line, so lets add every as standalone to be compliant with rfc6265 Discussion ---------- [HttpKernel][Client] Set cookie fix Bug fix: yes Feature addition: no Backwards compatibility break: no(?) Symfony2 tests pass: yes Fixes the following tickets: #2881 Only simple cookies can be stored in same line: * Used by now (__wrong__): `Set-Cookie: name1=value, name2=value` * Proper according to RFCs: `Set-Cookie: name1=value; name2=value` So lets add every as standalone ([next header](http://tools.ietf.org/html/rfc6265#section-3.1)) to be compliant with [RFC6265](http://tools.ietf.org/html/rfc6265). This fixes #2881.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no(?)
Symfony2 tests pass: yes
Fixes the following tickets: #2881
Only simple cookies can be stored in same line:
Set-Cookie: name1=value, name2=valueSet-Cookie: name1=value; name2=valueSo lets add every as standalone (next header) to be compliant with RFC6265. This fixes #2881.