8000 [FWBundle] Uniformize errors when a component is missing by dunglas · Pull Request #28867 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FWBundle] Uniformize errors when a component is missing #28867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2018
Merged

[FWBundle] Uniformize errors when a component is missing #28867

merged 1 commit into from
Oct 15, 2018

Conversation

dunglas
Copy link
Member
@dunglas dunglas commented Oct 14, 2018 •
edited
Loading
Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@dunglas dunglas force-pushed the better-component-messages branch from 47c7431 to fa3da4e Compare October 14, 2018 18:50
@dunglas dunglas removed the Bug label Oct 14, 2018
@fabpot
Copy link
Member
fabpot commented Oct 15, 2018

Thank you @dunglas.

@fabpot fabpot merged commit fa3da4e into symfony:3.4 Oct 15, 2018
fabpot added a commit that referenced this pull request Oct 15, 2018
@fabpot
minor #28867 [FWBundle] Uniformize errors when a component is missing…
dc11f7b 
… (dunglas)

This PR was merged into the 3.4 branch.

Discussion
----------

[FWBundle] Uniformize errors when a component is missing

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

fa3da4e [FWBundle] Uniformize errors when a component is missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dunglas @fabpot @nicolas-grekas @carsonbot
0