10000 [DependencyInjection] Skip empty proxy code by olvlvl · Pull Request #28861 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DependencyInjection] Skip empty proxy code #28861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2018
Merged

[DependencyInjection] Skip empty proxy code #28861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Skip empty proxy code
  • Loading branch information
@olvlvl @nicolas-grekas
olvlvl authored and nicolas-grekas committed Oct 20, 2018
commit baf6f8cc34b2df4cc3510541fbe63cd736583a30
4 changes: 3 additions & 1 deletion src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,9 @@ private function addProxyClasses()
$strip = '' === $this->docStar && method_exists('Symfony\Component\HttpKernel\Kernel', 'stripComments');

foreach ($definitions as $definition) {
$proxyCode = "\n".$this->getProxyDumper()->getProxyCode($definition);
if ("\n" === $proxyCode = "\n".$this->getProxyDumper()->getProxyCode($definition)) {
continue;
}
if ($strip) {
$proxyCode = "<?php\n".$proxyCode;
$proxyCode = substr(Kernel::stripComments($proxyCode), 5);
Expand Down
0