8000 [VarDumper] Scroll into view when searching by ro0NL · Pull Request #28854 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[VarDumper] Scroll into view when searching #28854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[VarDumper] Scroll into view when searching
  • Loading branch information
ro0NL committed Oct 14, 2018
commit 647a937abc8d8f30961132f7213cd1c41fd244aa
3 changes: 3 additions & 0 deletions src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,9 @@ function showCurrent(state)
if (currentNode) {
reveal(currentNode);
highlight(root, currentNode, state.nodes);
if ('scrollIntoView' in currentNode) {
currentNode.scrollIntoView();
}
}
counter.textContent = (state.isEmpty() ? 0 : state.idx + 1) + ' of ' + state.count();
}
Expand Down
0