8000 [Validator] Add a missing Polish translation by jakzal · Pull Request #28828 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Add a missing Polish translation #28828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2018
Merged

[Validator] Add a missing Polish translation #28828

merged 1 commit into from
Oct 12, 2018

Conversation

jakzal
Copy link
Contributor
@jakzal jakzal commented Oct 12, 2018
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@fabpot fabpot changed the base branch from master to 2.8 October 12, 2018 14:07
@fabpot fabpot force-pushed the validator-pl-translation branch from 2432694 to c1314b3 Compare October 12, 2018 14:07
@fabpot
Copy link
Member
fabpot commented Oct 12, 2018

Thank you @jakzal.

@fabpot fabpot merged commit c1314b3 into symfony:2.8 Oct 12, 2018
fabpot added a commit that referenced this pull request Oct 12, 2018
@fabpot
minor #28828 [Validator] Add a missing Polish translation (jakzal)
1a1a026 
This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #28828).

Discussion
----------

[Validator] Add a missing Polish translation

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

c1314b3 [Validator] Add a missing Polish translation
@jakzal jakzal deleted the validator-pl-translation branch October 12, 2018 15:12
@jakzal
Copy link
Contributor Author
jakzal commented Oct 12, 2018

Ah, i sent it to master as the translation doesn't exist in previous branches.

@fabpot
Copy link
Member
fabpot commented Oct 12, 2018

We are always merging into the lower branch (even if the translation does not exist there).

@jakzal
Copy link
Contributor Author
jakzal commented Oct 12, 2018

What about the en version? Currently it's missing at least one entry (that's why I sent my PR against master).

@fabpot
Copy link
Member
fabpot commented Oct 12, 2018

The files are indeed not always synced (especially for the en version as it is part of the original PR which is always on master). From time to time, we try to re-sync the translations file though.

@jakzal jakzal mentioned this pull request Oct 12, 2018
Merged
fabpot added a commit that referenced this pull request Oct 12, 2018
@fabpot
minor #28841 Sync English translations (jakzal)
7d9ae2f 
This PR was merged into the 2.8 branch.

Discussion
----------

Sync English translations

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? |no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #28828 (comment)
| License       | MIT
| Doc PR        | -

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

bb57352 Add a missing English translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Validator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakzal @fabpot @javiereguiluz @xabbuh @carsonbot
0