invalidate stale commits for PRs too #28788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
xabbuh
commented
Oct 9, 2018
| @@ -104,8 +104,7 @@ function getContentHash(array $composerJson) | |||
| } | |||
| } | |||
|
|
|||
| if (!$referencedCommits || (isset($_SERVER['TRAVIS_PULL_REQUEST']) && 'false' !== $_SERVER['TRAVIS_PULL_REQUEST'])) { | |||
| // cached commits cannot be stale for PRs | |||
There was a problem hiding this comment.
it seems they can: https://travis-ci.org/symfony/symfony/jobs/438809475
There was a problem hiding this comment.
That's good: now than we use flex as an accelerator, this is not really slow anymore.
fabpot
approved these changes
Oct 10, 2018
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Oct 10, 2018
This PR was merged into the 2.8 branch. Discussion ---------- invalidate stale commits for PRs too | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- aee63f5 invalidate stale commits for PRs too
|
@nicolas-grekas Can you please check this change nonetheless? It makes build pass again, but I am not fully sure that I did not break any legitimate use case (i.e. maybe we now invalidate too often and thus slowing builds down again). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.