10000 [Console] Don't return early as this bypasses the auto exit feature by duncan3dc · Pull Request #28664 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] Don't return early as this bypasses the auto exit feature #28664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2018
Merged

[Console] Don't return early as this bypasses the auto exit feature #28664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Don't return early as this bypasses the auto exit feature
  • Loading branch information
@duncan3dc
duncan3dc committed Oct 1, 2018
commit b6c17dfb5e6aaff8a33482612ae2a6e6c8df1c0b
2 changes: 0 additions & 2 deletions src/Symfony/Component/Console/Application.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,6 @@ public function run(InputInterface $input = null, OutputInterface $output = null
} else {
$exitCode = 1;
}

return $exitCode;
} finally {
// if the exception handler changed, keep it
// otherwise, unregister $renderException
Expand Down
0