[Console] Fix clearing sections containing questions #28638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierredup
reviewed
Sep 29, 2018
| @@ -123,6 +124,10 @@ private function doAsk(OutputInterface $output, Question $question) | |||
| $ret = trim($this->autocomplete($output, $question, $inputStream, \is_array($autocomplete) ? $autocomplete : iterator_to_array($autocomplete, false))); | |||
| } | |||
|
|
|||
| if ($output instanceof ConsoleSectionOutput) { | |||
| $output->addContent($ret); | |||
There was a problem hiding this comment.
How will this work with hidden input? There might not be any additional lines to clear in that case
8000
There was a problem hiding this comment.
Answering questions still implies to hit enter, empty and hidden inputs result in a blank line on the screen. Just tried it, works as expected with hidden questions
pierredup
approved these changes
Sep 29, 2018
|
(4.1 or master? see target branch vs description) |
|
@nicolas-grekas 4.1, fixed thanks |
nicolas-grekas
approved these changes
Oct 3, 2018
0e9e6b4 to
81ec57d
Compare
fabpot
requested changes
Oct 3, 2018
|
|
||
| class ConsoleSectionOutputTest extends TestCase | ||
| { | ||
| private $stream; | ||
|
|
||
| protected function setUp() | ||
| { | ||
| $this->stream = fopen('php://memory', 'r+', false); | ||
| $this->stream = fopen('php://memory', 'r+b', false); |
There was a problem hiding this comment.
should be reverted /cc @nicolas-grekas
|
|
||
| public function testClearSectionContainingQuestion() | ||
| { 8000 | ||
| $inputStream = fopen('php://memory', 'r+b', false); |
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Oct 3, 2018
…asr) This PR was merged into the 4.1 branch. Discussion ---------- [Console] Fix clearing sections containing questions | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28615 | License | MIT | Doc PR | n/a Given: ```php $section = $output->section(); $question = "What's your name?"; $name = (new QuestionHelper())->ask($input, $section, new Question($question)); $section->clear(); $section->writeln("$question (<info>$name</info>)"); ``` Before:  After:  Commits ------- 81ec57d [Console] Fix clearing sections containing questions
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given:
Before:
After:
