[Finder] fixed root directory access for ftp/sftp wrapper #28604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Sep 29, 2018
fabpot
approved these changes
Oct 3, 2018
|
Thank you @DerDu. |
fabpot
added a commit
that referenced
this pull request
Oct 3, 2018
…(DerDu) This PR was squashed before being merged into the 3.4 branch (closes #28604). Discussion ---------- [Finder] fixed root directory access for ftp/sftp wrapper | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27423 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> This fixes a flaw introduced in 3.4.7 by #26763 In order to access the root folder with ftp wrapper, there MUST BE a slash present. - Currently: from 3.4.7 on it just ```rtrim``` all seperators (```/```, ```\```) from directories - Now: IF the directory is a (s)ftp:// wrapper (```#^s?ftp://#```) this fix just adds a slash (```/```) again Commits ------- 9630a38 [Finder] fixed root directory access for ftp/sftp wrapper
fabpot
added a commit
that referenced
this pull request
Nov 15, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Finder] Allow ssh2 stream wrapper for sftp Same fix as #28604 but for the ssh2.sftp wrapper. | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #28604 maybe | License | MIT | Doc PR | Without this patch, we can't use the finder with ssh2.sftp connections. ```php $connection = \ssh2_connect('host', 22); \ssh2_auth_password($connection, 'user', 'pass'); $sftp = \ssh2_sftp($connection); $path = "ssh2.sftp://".intval($sftp)."/"; $finder = new Finder(); foreach ($finder->in($path)->files() as $directory) { dump(file_get_contents($directory)); } ``` Without the patch: > RecursiveDirectoryIterator::__construct(ssh2.sftp://838): failed to open dir: operation failed Commits ------- e6c9d77 [Finder] Allow ssh2 stream wrapper for sftp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a flaw introduced in 3.4.7 by #26763
In order to access the root folder with ftp wrapper, there MUST BE a slash present.
rtrimall seperators (/,\) from directories#^s?ftp://#) this fix just adds a slash (/) again