8000 ldap query minor refactoring by ronfroy · Pull Request #28459 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

ldap query minor refactoring #28459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

ldap query minor refactoring #28459

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e73dad
ldap query minor refactoring
ronfroy Sep 13, 2018
f9413e0
fix
ronfroy Sep 13, 2018
21fb399
revert
ronfroy Sep 17, 2018
185ffd1
revert
ronfroy Sep 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
8000
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@ronfroy
ronfroy committed Sep 13, 2018
commit f9413e09265e837868f9b2ebc7cbb3c34b59e7a5
2 changes: 1 addition & 1 deletion src/Symfony/Component/Ldap/Adapter/ExtLdap/Query.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public function execute()
QueryInterface::SCOPE_SUB => 'ldap_search',
);

if (\in_array($this->options['scope'], $funcMap, true)) {
if (!\array_key_exists($this->options['scope'], $funcMap)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"isset" would do it

throw new LdapException(sprintf('Could not search in scope "%s".', $this->options['scope']));
}

Expand Down
0