10BC0 Remove usage of backticks in exception messages by fabpot · Pull Request #28398 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Remove usage of backticks in exception messages #28398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2018
Merged

Remove usage of backticks in exception messages #28398

merged 1 commit into from
Sep 10, 2018

Conversation

@fabpot
Copy link
Member
@fabpot fabpot commented Sep 8, 2018
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Exception messages are not formatted in Markdown, so let's use " instead everywhere for more consistency.

@fabpot fabpot requested a review from xabbuh as a code owner September 8, 2018 06:41
@chalasr
Copy link
Member
chalasr commented Sep 8, 2018

This breaks some tests

nicolas-grekas
nicolas-grekas approved these changes Sep 8, 2018
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(rebase needed)

@nicolas-grekas nicolas-grekas added this to the next milestone Sep 8, 2018
@fabpot fabpot force-pushed the exception-messages-ticks branch from b93594b to e5bb5e2 Compare September 10, 2018 07:26
@fabpot fabpot merged commit e5bb5e2 into symfony:master Sep 10, 2018
fabpot added a commit that referenced this pull request Sep 10, 2018
@fabpot
minor #28398 Remove usage of backticks in exception messages (fabpot)
05410c5 
This PR was merged into the 4.2-dev branch.

Discussion
----------

Remove usage of backticks in exception messages

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Exception messages are not formatted in Markdown, so let's use `"` instead everywhere for more consistency.

Commits
-------

e5bb5e2 removed usage of backticks in exception messages
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.2 Nov 1, 2018
@fabpot fabpot deleted the exception-messages-ticks branch January 14, 2019 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees

No one assigned

Labels

Status: Reviewed

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

5 participants

@fabpot @chalasr @javiereguiluz @nicolas-grekas @carsonbot
0