8000 [DI] Fix dumping some complex service graphs by nicolas-grekas · Pull Request #28366 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DI] Fix dumping some complex service graphs #28366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2018
Merged

[DI] Fix dumping some complex service graphs #28366

merged 1 commit into from
Sep 5, 2018

Conversation

nicolas-grekas
Copy link
Member
@nicolas-grekas nicolas-grekas commented Sep 4, 2018 •
edited
Loading
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28296 (and its duplicates #28355 & #28362 + possibly #28304)
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Sep 4, 2018
This was referenced Sep 4, 2018
Closed
Closed
Closed
Closed
@skalpa
Copy link
Contributor
skalpa commented Sep 4, 2018 •
edited
Loading

It fixed it on my side. Thank you 👍

@FabienSalles
Copy link
Contributor

It fixed it on my side too.

nicolas-grekas added a commit that referenced this pull request Sep 5, 2018
@nicolas-grekas
bug #28366 [DI] Fix dumping some complex service graphs (nicolas-grekas)
8851c14 
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Fix dumping some complex service graphs

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28296 (and its duplicates #28355 & #28362 ~+ possibly #28304~)
| License       | MIT
| Doc PR        | -

Commits
-------

769fd4b [DI] Fix dumping some complex service graphs
@nicolas-grekas nicolas-grekas merged commit 769fd4b into symfony:3.4 Sep 5, 2018
@fabpot
Copy link
Member
fabpot commented Sep 5, 2018

Thank you @nicolas-grekas.

@nicolas-grekas nicolas-grekas deleted the di-fix branch September 5, 2018 07:28
@XWB
Copy link
Contributor
XWB commented Sep 13, 2018

I'm now getting other errors:

(1/1) ErrorExceptionNotice: Undefined variable: f
--
in srcDevDebugProjectContainer.php line 1786
(2/2) Twig_Error_Syntax
Unknown "abbr_class" filter.

This was referenced Sep 30, 2018
Merged
Merged
@discordier discordier mentioned this pull request Oct 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug DependencyInjection Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
6 participants
@nicolas-grekas @skalpa @FabienSalles @fabpot @XWB @carsonbot
0