Don't "replace" symfony/contracts #28236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The outcome is interesting as well: it means we can't PR a change on the contract and in the code at the same time without Travis to fail (which is good). |
|
Yes we can, as we create local packages for each modified components (including Contracts.) |
fabpot
approved these changes
Aug 27, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Aug 27, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- Don't "replace" symfony/contracts | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Maintaining an exact version number here is going to be painful on the long run. Let's free us from this burden. Commits ------- 7b4e5cc Don't "replace" symfony/contracts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintaining an exact version number here is going to be painful on the long run.
Let's free us from this burden.