[WebProfilerBundle] fix wrong url when base path is the index #28183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is for 3.4, can you rebase + retarget 3.4 please? |
|
Thank you @ismail1432. |
fabpot
added a commit
that referenced
this pull request
Sep 4, 2018
…dex (ismail1432) This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #28183). Discussion ---------- [WebProfilerBundle] fix wrong url when base path is the index | Q | A | ------------- | --- | Branch? | >= 3.4 | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #27846 <!-- #-prefixed issue number(s), if any --> | License | MIT The `FileLinkFormatter` create a wrong url because it's using [getBaseUrl](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpFoundation/Request.php#L870) that render the script filename, the problem is that in this class it's used twice, first time with the [getBaseUrl method](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/Debug/FileLinkFormatter.php#L99) and another time with the [generate method](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/Debug/FileLinkFormatter.php#L77). Just switch to `getBasePath` solve the issue. WDYT ? Commits ------- 897615e change baseUrl to basePath to fix wrong profiler url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FileLinkFormattercreate a wrong url because it's using getBaseUrl that render the script filename, the problem is that in this class it's used twice, first time with the getBaseUrl method and another time with the generate method. Just switch togetBasePathsolve the issue.WDYT ?