[Form] Fix PHPDoc for FormConfigBuilder $dataClass argument #27954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
approved these changes
Jul 14, 2018
xabbuh
approved these changes
Jul 14, 2018
chalasr
approved these changes
Jul 14, 2018
fabpot
approved these changes
Jul 15, 2018
|
Thank you @emodric. |
fabpot
added a commit
that referenced
this pull request
Jul 15, 2018
…ent (emodric) This PR was merged into the 2.8 branch. Discussion ---------- [Form] Fix PHPDoc for FormConfigBuilder $dataClass argument | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A `$dataClass` constructor argument of `FormConfigBuilder` obviously allows `null` as its value and it even has a `?string` typehint in `master` branch, so this fixes the PHPDoc typehint to match. Commits ------- 9854a26 [Form] Fix PHPDoc for FormConfigBuilder $dataClass argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$dataClassconstructor argument ofFormConfigBuilderobviously allowsnullas its value and it even has a?stringtypehint inmasterbranch, so this fixes the PHPDoc typehint to match.