8000 Fix tests by dunglas · Pull Request #27939 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Fix tests #27939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2018
Merged

Fix tests #27939

merged 1 commit into from
Jul 19, 2018

Conversation

dunglas
Copy link
Member
@dunglas dunglas commented Jul 13, 2018
Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Makes Travis green. It's a temporary fix while the 2.6 branch of Doctrine isn't merged in the 2.7 one.
Not sure if it is worth a merge.

@fabpot
Copy link
Member
fabpot commented Jul 19, 2018

Thank you @dunglas.

@fabpot fabpot merged commit aaf7e88 into symfony:3.4 Jul 19, 2018
fabpot added a commit that referenced this pull request Jul 19, 2018
This PR was merged into the 3.4 branch.

Discussion
----------

Fix tests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Makes Travis green. It's a temporary fix while the 2.6 branch of Doctrine isn't merged in the 2.7 one.
Not sure if it is worth a merge.

Commits
-------

aaf7e88 Fix tests
649C Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0