8000 [DependencyInjection] add missing test for #27710 by xabbuh · Pull Request #27915 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DependencyInjection] add missing test for #27710 #27915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2018
Merged

[DependencyInjection] add missing test for #27710 #27915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions src/Symfony/Component/DependencyInjection/Tests/Compiler/ValidateEnvPlaceholdersPassTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,18 @@ public function testConfigurationWithoutRootNode(): void
$this->addToAssertionCount(1);
}

public function testEmptyConfigFromMoreThanOneSource()
{
$container = new ContainerBuilder();
$container->registerExtension(new EnvExtension(new ConfigurationWithArrayNodeRequiringOneElement()));
$container->loadFromExtension('env_extension', array());
$container->loadFromExtension('env_extension', array());

$this->doProcess($container);

$this->addToAssertionCount(1);
}

public function testDiscardedEnvInConfig(): void
{
$container = new ContainerBuilder();
Expand Down Expand Up @@ -313,6 +325,24 @@ public function getConfigTreeBuilder()
}
}

class ConfigurationWithArrayNodeRequiringOneElement implements ConfigurationInterface
{
public function getConfigTreeBuilder()
{
$treeBuilder = new TreeBuilder();
$treeBuilder->root('env_extension')
->children()
->arrayNode('nodes')
->isRequired()
->requiresAtLeastOneElement()
->scalarPrototype()->end()
->end()
->end();

return $treeBuilder;
}
}

class EnvExtension extends Extension
{
private $configuration;
Expand All @@ -335,6 +365,10 @@ public function getConfiguration(array $config, ContainerBuilder $container)

public function load(array $configs, ContainerBuilder $container)
{
if (!array_filter($configs)) {
return;
}

try {
$this->config = $this->processConfiguration($this->getConfiguration($configs, $container), $configs);
} catch (TreeWithoutRootNodeException $e) {
Expand Down
0