8000 Fix the detection of the Process new argument by stof · Pull Request #27902 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fix the detection of the Process new argument #27902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2018
Merged

Fix the detection of the Process new argument #27902

merged 1 commit into from
Jul 9, 2018

Conversation

stof
Copy link
Member
@stof stof commented Jul 9, 2018
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

This fixes the detection of the new method signature when triggering the deprecation warning. The new $env parameter is the second argument, not the first one.

@stof stof added the Process label Jul 9, 2018
@xabbuh xabbuh added this to the 3.4 milestone Jul 9, 2018
@nicolas-grekas
Copy link
Member

Thank you @stof.

@nicolas-grekas nicolas-grekas merged commit 57e95f3 into symfony:3.4 Jul 9, 2018
nicolas-grekas added a commit that referenced this pull request Jul 9, 2018
@nicolas-grekas
bug #27902 Fix the detection of the Process new argument (stof)
0fcc874 
This PR was merged into the 3.4 branch.

Discussion
----------

Fix the detection of the Process new argument

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

This fixes the detection of the new method signature when triggering the deprecation warning. The new `$env` parameter is the second argument, not the first one.

Commits
-------

57e95f3 Fix the detection of the Process new argument
This was referenced Jul 23, 2018
Merged
Merged
Merged
@stof stof deleted the fix_deprecation_warning branch July 24, 2018 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug Process Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@stof @nicolas-grekas @xabbuh @carsonbot
0