8000 improve deprecation messages by xabbuh · Pull Request #27877 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

improve deprecation messages #27877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2018
Merged

improve deprecation messages #27877

merged 1 commit into from
Jul 9, 2018

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Jul 6, 2018
Q A
Branch? 4.1
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.1 milestone Jul 6, 2018
@xabbuh xabbuh requested a review from lyrixx as a code owner July 6, 2018 11:49
chalasr
chalasr reviewed Jul 6, 2018
View reviewed changes
src/Symfony/Component/Security/Core/Authentication/Token/AbstractToken.php Outdated
@@ -261,7 +261,7 @@ private function hasUserChanged(UserInterface $user)
}

if ($this->user instanceof AdvancedUserInterface && $user instanceof AdvancedUserInterface) {
@trigger_error(sprintf('Checking for the AdvancedUserInterface in %s has been deprecated in 4.1. Implement the %s to check if the user has been changed,', __METHOD__, EquatableInterface::class), E_USER_DEPRECATED);
@trigger_error(sprintf('Checking for the AdvancedUserInterface in "%s()" has been deprecated in 4.1. Implement the %s to check if the user has been changed,', __METHOD__, EquatableInterface::class), E_USER_DEPRECATED);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we change it to is deprecated since Symfony 4.1 for consistency? same below

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, changed it

@xabbuh xabbuh force-pushed the deprecation-improvements-4.1 branch from e5c2aa3 to e4ae5a4 Compare July 6, 2018 14:52
@chalasr chalasr mentioned this pull request Jul 8, 2018
Merged
@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit e4ae5a4 into symfony:4.1 Jul 9, 2018
nicolas-grekas added a commit that referenced this pull request Jul 9, 2018
@nicolas-grekas
minor #27877 improve deprecation messages (xabbuh)
bbe3ce8 
This PR was merged into the 4.1 branch.

Discussion
----------

improve deprecation messages

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

e4ae5a4 improve deprecation messages
@xabbuh xabbuh deleted the deprecation-improvements-4.1 branch July 9, 2018 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @nicolas-grekas @lyrixx @chalasr @carsonbot
0