8000 [Doctrine Bridge] Fixed usage of wrong variable when tagged subscriber is invalid by stloyd · Pull Request #27812 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Doctrine Bridge] Fixed usage of wrong variable when tagged subscriber is invalid #27812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Doctrine Bridge] Fixed usage of wrong variable when tagged subscriber is invalid #27812

wants to merge 1 commit into from

Conversation

stloyd
Copy link
Contributor
@stloyd stloyd commented Jul 3, 2018
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27811
License MIT

This change prevents error when invalid subscriber is being used.

Expected result:

The Doctrine connection "root" referenced in service "stof_doctrine_extensions.listener.sluggable" does not exist. Available connections names: default

Actual error:

Notice: Array to string conversion

@stloyd
Copy link
Contributor Author
stloyd commented Jul 3, 2018 •
edited
Loading

Just noticed that this bug exists in version 2.8: #27813

@stof
Copy link
Member
stof commented Jul 3, 2018

is this PR still needed due to #27813

@chalasr
Copy link
Member
chalasr commented Jul 3, 2018

Closing in favor of #27813.

@chalasr chalasr closed this Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stloyd @stof @chalasr @carsonbot
0