Add color support for Hyper terminal . #27794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. We consider these as bug fixes so it should be fixed on 2.8. |
|
i have made 2 other PRs at |
|
@nicolas-grekas i think that's all, i have search the repository for similar code and i found these checks in |
javiereguiluz
approved these changes
Jul 3, 2018
There was a problem hiding this comment.
@azjezz thanks! This is a nice first contribution to Symfony.
fabpot
approved these changes
Jul 3, 2018
|
Thank you @azjezz. |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2018
This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #27794). Discussion ---------- Add color support for Hyper terminal . | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Added color support for [Hyper terminal](https://hyper.is), also shade characters support for progress bar.  Commits ------- 2ab7bcf Add color support for Hyper terminal .
fabpot
added a commit
to symfony/polyfill
that referenced
this pull request
Jul 3, 2018
…00_support. (azjezz) This PR was merged into the 1.8-dev branch. Discussion ---------- Checks the enviroment for Hyper Termianl on sapi_windows_vt100_support. see : [symfony/symfony#27794](symfony/symfony#27794). Commits ------- 7ee2340 Update Php72.php
This was referenced Jul 23, 2018
Merged
Merged
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Dec 8, 2023
… (theofidry) This PR was merged into the 5.4 branch. Discussion ---------- [Console] Fix color support check on non-Windows platforms | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #45917 | License | MIT Currently checking the color support based on `ANSICON`, `ConEmuANSI=ON` or `TERM=xTerm` is done only for Widows. I could not find any reason as to why and it does not make much sense as it is. Especially if we consider that `TERM=xTerm` is a term check and we do another one (not Widows specific) which is `TERM_PROGRAM=Hyper`. This potentially fixes #45917. This also looks more in line with the intent (based on the title) of #27831 and #27794. Commits ------- 285518d detect colors on not windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added color support for Hyper terminal, also shade characters support for progress bar.