8000 [FrameworkBundle] Remove useless code in AbstractPhpFileCacheWarmer by nicolas-grekas · Pull Request #27565 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Remove useless code in AbstractPhpFileCacheWarmer #27565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[FrameworkBundle] Remove useless code in AbstractPhpFileCacheWarmer #27565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[FrameworkBundle] Remove useless code in AbstractPhpFileCacheWarmer
  • Loading branch information
@nicolas-grekas
nicolas-grekas committed Jun 9, 2018
commit 74106a85c093fb752e27c2a1e045b6e8b9919b2f
7 changes: 2 additions & 5 deletions src/Symfony/Bundle/FrameworkBundle/CacheWarmer/AbstractPhpFileCacheWarmer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public function isOptional()
*/
public function warmUp($cacheDir)
{
$arrayAdapter = new ArrayAdapter();
$arrayAdapter = new ArrayAdapter(0, false);

spl_autoload_register(array(PhpArrayAdapter::class, 'throwOnRequiredClass'));
try {
Expand All @@ -63,10 +63,7 @@ public function warmUp($cacheDir)
spl_autoload_unregister(array(PhpArrayAdapter::class, 'throwOnRequiredClass'));
}

// the ArrayAdapter stores the values serialized
// to avoid mutation of the data after it was written to the cache
// so here we un-serialize the values first
$values = array_map(function ($val) { return null !== $val ? unserialize($val) : null; }, $arrayAdapter->getValues());
$values = $arrayAdapter->getValues();

$this->warmUpPhpArrayAdapter(new PhpArrayAdapter($this->phpArrayFile, $this->fallbackPool), $values);

Expand Down
0