Update Finder.php #27545
Merged
Update Finder.php #27545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected return type which causes following error with (psalm)[https://getpsalm.org/] ``` ERROR: PossiblyInvalidArgument - src/Command/Utils/CheckVendorDependencies.php:170:62 - Argument 1 of iterator_to_array expects Traversable, possibly different type array<mixed, Symfony\Component\Finder\SplFileInfo>|Iterator provided $directories = array_map($closure, iterator_to_array($finder->getIterator())); ```
|
Thank you @tarlepp. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 7, 2018
This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #27545). Discussion ---------- Update Finder.php Corrected return type which causes following error with [psalm](https://getpsalm.org/) ``` ERROR: PossiblyInvalidArgument - src/Command/Utils/CheckVendorDependencies.php:170:62 - Argument 1 of iterator_to_array expects Traversable, possibly different type array<mixed, Symfony\Component\Finder\SplFileInfo>|Iterator provided $directories = array_map($closure, iterator_to_array($finder->getIterator())); ``` | Q | A | ------------- | --- | Branch? | 4.1 <!-- see below --> | Bug fix? | yes (just docblock bug - nothing serious) | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md file 8000 s --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | - <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | - <!-- required for new features --> <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Commits ------- a74ee8d Update Finder.php
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Jun 8, 2018
The SplFileInfo class indeed does exist in the Symfony\Component\Finder namespace.
|
Reverted in #27553: The SplFileInfo class indeed does exist in the Symfony\Component\Finder namespace. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 8, 2018
This PR was merged into the 2.8 branch. Discussion ---------- [Finder] revert #27545 | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The SplFileInfo class indeed [does exist](https://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/Finder/SplFileInfo.php) in the Symfony\Component\Finder namespace. Commits ------- 8fd4b44 revert #27545
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected return type which causes following error with psalm