[WebServerBundle] Improve the error message when web server is already running #27542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that "warning" and "error" both render a big red block.
|
nicolas-grekas
approved these changes
Jun 7, 2018
fabpot
approved these changes
Jun 8, 2018
|
Thank you @Nyholm. |
fabpot
added a commit
that referenced
this pull request
Jun 8, 2018
…ver is already running (Nyholm) This PR was squashed before being merged into the 4.2-dev branch (closes #27542). Discussion ---------- [WebServerBundle] Improve the error message when web server is already running | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | na I understand that this change seams weird. I've just been in a training where 3 sets of eyes did not figure out why the web server did not start. We where faced with the message: > The web server is already running (listening on http://127.0.0.1:8000). Which I read as: > There is already an other service listening on port 8000. I know I have myself to blame for not reading properly. But I feel this could be improved some how. So here is a suggestion. I updated the message and I made it a warning. Commits ------- b79f38c [WebServerBundle] Improve the error message when web server is already running
|
Thank you for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand that this change seams weird. I've just been in a training where 3 sets of eyes did not figure out why the web server did not start.
We where faced with the message:
Which I read as:
I know I have myself to blame for not reading properly. But I feel this could be improved some how. So here is a suggestion. I updated the message and I made it a warning.