8000 [FrameworkBundle][SecurityBundle] Remove no-longer necessary Bundle::registerCommands override by ogizanagi · Pull Request #27497 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle][SecurityBundle] Remove no-longer necessary Bundle::registerCommands override #27497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2018
Merged

[FrameworkBundle][SecurityBundle] Remove no-longer necessary Bundle::registerCommands override #27497

merged 1 commit into from
Jun 4, 2018

Conversation

ogizanagi
Copy link
Contributor
@ogizanagi ogizanagi commented Jun 4, 2018 •
edited
Loading
Q A
Branch? 4.1
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

These two bundles requires symfony/http-kernel:^4.1 which already makes Bundle::registerCommands a noop.

@nicolas-grekas nicolas-grekas added this to the 4.1 milestone Jun 4, 2018
@nicolas-grekas
Copy link
Member

Thank you @ogizanagi.

@nicolas-grekas nicolas-grekas merged commit 7c97846 into symfony:4.1 Jun 4, 2018
nicolas-grekas added a commit that referenced this pull request Jun 4, 2018
@nicolas-grekas
minor #27497 [FrameworkBundle][SecurityBundle] Remove no-longer neces…
cc0320f 
…sary Bundle::registerCommands override (ogizanagi)

This PR was merged into the 4.1 branch.

Discussion
----------

[FrameworkBundle][SecurityBundle] Remove no-longer necessary Bundle::registerCommands override

| Q             | A
| ------------- | ---
| Branch?       | 4.1 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

These two bundles requires `symfony/http-kernel:^4.1` which already makes [`Bundle::registerCommands`](https://github.com/symfony/symfony/blob/49ad34b78ec83ac7b65506a73e6003aba5860333/src/Symfony/Component/HttpKernel/Bundle/Bundle.php#L143-L145) a noop.

Commits
-------

7c97846 [FrameworkBundle][SecurityBundle] Remove no-longer necessary Bundle::registerCommands override
@ogizanagi ogizanagi deleted the rm_unecessary_bundles_register_commands_override branch June 4, 2018 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
FrameworkBundle SecurityBundle Status: Needs Review
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ogizanagi @nicolas-grekas @carsonbot
0