8000 [BrowserKit] Fix a BC break in Client affecting Panthère by dunglas · Pull Request #27485 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[BrowserKit] Fix a BC break in Client affecting Panthère #27485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2018
Merged

[BrowserKit] Fix a BC break in Client affecting Panthère #27485

merged 1 commit into from
Jun 4, 2018

Conversation

dunglas
Copy link
Member
@dunglas dunglas commented Jun 4, 2018
Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets dunglas/panthere#25
License MIT
Doc PR n/a

@dunglas
Copy link
Member Author
dunglas commented Jun 4, 2018

Fabbot error is a false positive (and not related to this fix).

@dunglas dunglas mentioned this pull request Jun 4, 2018
Closed
@nicolas-grekas nicolas-grekas added this to the 4.1 milestone Jun 4, 2018
nicolas-grekas
nicolas-grekas reviewed Jun 4, 2018
View reviewed changes
src/Symfony/Component/BrowserKit/Client.php Outdated
{
$form->setValues($values);
$serverParameters = 3 === \func_num_args() ? func_get_arg(2) : array();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 < \func_num_args()

fabpot
fabpot approved these changes 8000 Jun 4, 2018
View reviewed changes
@fabpot fabpot force-pushed the fix-panthere-25 branch from b73f401 to e3aa90f Compare June 4, 2018 17:32
@fabpot
Copy link
Member
fabpot commented Jun 4, 2018

Thank you @dunglas.

@fabpot fabpot merged commit e3aa90f into symfony:4.1 Jun 4, 2018
fabpot added a commit that referenced this pull request Jun 4, 2018
bug #27485 [BrowserKit] Fix a BC break in Client affecting Panthère (…
49ad34b 
…dunglas)

This PR was squashed before being merged into the 4.1 branch (closes #27485).

Discussion
----------

[BrowserKit] Fix a BC break in Client affecting Panthère

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | dunglas/panthere#25
| License       | MIT
| Doc PR        | n/a

Commits
-------

e3aa90f [BrowserKit] Fix a BC break in Client affecting Panthère
@dunglas dunglas mentioned this pull request Jun 5, 2018
Merged
@dunglas dunglas deleted the fix-panthere-25 branch June 5, 2018 14:51
@dunglas dunglas mentioned this pull request Jun 19, 2018
Closed
@fabpot fabpot mentioned this pull request Jun 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh xabbuh approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
BrowserKit Bug Status: Reviewed
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
6 participants
@dunglas @fabpot @nicolas-grekas @xabbuh @chalasr @carsonbot
0