[FrameworkBundle] Deprecate auto-injection of the container in AbstractController instances #27462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
approved these changes
Jun 1, 2018
curry684
approved these changes
Jun 1, 2018
chalasr
approved these changes
Jun 1, 2018
20uf
approved these changes
8000
Jun 2, 2018
xabbuh
approved these changes
Jun 2, 2018
Tobion
approved these changes
Jun 2, 2018
dunglas
approved these changes
Jun 4, 2018
| } | ||
|
|
||
| private function configureController($controller) | ||
| private function configureController($controller, $class) |
dunglas
reviewed
Jun 4, 2018
| $controller->setContainer($previousContainer); | ||
| if ($controller instanceof AbstractController) { | ||
| $previousContainer = $controller->setContainer($this->container); | ||
| if (null !== $previousContainer) { |
There was a problem hiding this comment.
This test can maybe be inverted if (null === $previousContainer) else for clarity?
e90e920 to
38277b7
Compare
…ctController instances
38277b7 to
e2f344f
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jun 4, 2018
…ainer in AbstractController instances (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [FrameworkBundle] Deprecate auto-injection of the container in AbstractController instances | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Should enhance DX by preventing situations like #27436. Commits ------- e2f344f [FrameworkBundle] Deprecate auto-injection of the container in AbstractController instances
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should enhance DX by preventing situations like #27436.