8000 [DebugBundle] Fix dump/die doesn't work with server dumper by ogizanagi · Pull Request #27397 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DebugBundle] Fix dump/die doesn't work with server dumper #27397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[DebugBundle] Fix dump/die doesn't work with server dumper #27397

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a11b61
[DebugBundle] Fix dump/die doesn't work with server dumper
ogizanagi May 8, 2018
059c6dc
[VarDumper] Server dumper tweaks
nicolas-grekas Jun 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[VarDumper] Server dumper tweaks
  • Loading branch information
@nicolas-grekas @ogizanagi
nicolas-grekas authored and ogizanagi committed Jun 20, 2018
commit 059c6dc60bd29bfe13f8646f42f812a47e2ccb1e
2 changes: 1 addition & 1 deletion src/Symfony/Component/VarDumper/Dumper/AbstractDumper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ public function dump(Data $data, $output = null)
*/
protected function dumpLine($depth)
{
call_user_func($this->lineDumper, $this->line, $depth, $this->indentPad);
\call_user_func($this->lineDumper, $this->line, $depth, $this->indentPad);
$this->line = '';
}

Expand Down
4 changes: 3 additions & 1 deletion src/Symfony/Component/VarDumper/Dumper/ContextProvider/CliContextProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,10 @@
* Tries to provide context on CLI.
*
* @author Maxime Steinhausser <maxime.steinhausser@gmail.com>
*
* @final
*/
final class CliContextProvider implements ContextProviderInterface
class CliContextProvider implements ContextProviderInterface
{
public function getContext(): ?array
{
Expand Down
4 changes: 3 additions & 1 deletion src/Symfony/Component/VarDumper/Dumper/ContextProvider/RequestContextProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@
* Tries to provide context from a request.
*
* @author Maxime Steinhausser <maxime.steinhausser@gmail.com>
*
* @final
*/
final class RequestContextProvider implements ContextProviderInterface
class RequestContextProvider implements ContextProviderInterface
{
private $requestStack;
private $cloner;
Expand Down
4 changes: 3 additions & 1 deletion src/Symfony/Component/VarDumper/Dumper/ContextProvider/SourceContextProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@
*
* @author Nicolas Grekas <p@tchwork.com>
* @author Maxime Steinhausser <maxime.steinhausser@gmail.com>
*
* @final
*/
final class SourceContextProvider implements ContextProviderInterface
class SourceContextProvider implements ContextProviderInterface
{
private $limit;
private $charset;
Expand Down
14 changes: 6 additions & 8 deletions src/Symfony/Component/VarDumper/Resources/css/htmlDescriptor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,6 @@ a {
a:hover {
text-decoration: underline;
}
code {
color: #cc2255;
background-color: #f7f7f9;
border: 1px solid #e1e1e8;
border-radius: 3px;
margin-right: 5px;
padding: 0 3px;
}
.text-small {
font-size: 12px !important;
}
Expand Down Expand Up @@ -60,6 +52,12 @@ article > header > .row > h2 {
article > header > .row > h2 > code {
white-space: nowrap;
user-select: none;
color: #cc2255;
background-color: #f7f7f9;
border: 1px solid #e1e1e8;
border-radius: 3px;
margin-right: 5px;
padding: 0 3px;
}
article > header > .row > time.col {
flex: 0;
Expand Down
0