[Github] Update the pull-request template #27376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
May 25, 2018
jvasseur
reviewed
May 25, 2018
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| | Q | A | |||
| | ------------- | --- | |||
| | Branch? | master for features / 2.7 up to 4.0 for bug fixes <!-- see below --> | |||
| | Branch? | master for features / 2.8 up to 4.0 for bug fixes <!-- see below --> | |||
There was a problem hiding this comment.
4.0 can be replaced with 4.1 at the same time.
There was a problem hiding this comment.
Good point. Changed 😉
chalasr
approved these changes
May 25, 2018
|
4.0 is maintained until July 2018, right? |
|
@fabpot sure, the master piece agrees; but if we say "up to" we need to mention the upper branch that isn't master I think. And it's 4.1 now :) |
nicolas-grekas
approved these changes
May 25, 2018
ogizanagi
approved these changes
May 25, 2018
2154b4f to
99327a6
Compare
|
Thank you @sroze. |
nicolas-grekas
added a commit
that referenced
this pull request
May 25, 2018
This PR was squashed before being merged into the 2.8 branch (closes #27376). Discussion ---------- [Github] Update the pull-request template | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ø | License | MIT | Doc PR | ø 2.7 is end of life. Commits ------- 99327a6 [Github] Update the pull-request template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.7 is end of life.