Tweak Argon2 test config #27371
Merged
Tweak Argon2 test config #27371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory cost 8 seems to be lowest value accepted on my machine ``` Testing Symfony\Component\Security\Core\Tests\Encoder\Argon2iPasswordEncoderTest E.... 5 / 5 (100%) Time: 114 ms, Memory: 4.00MB There was 1 error: 1) Symfony\Component\Security\Core\Tests\Encoder\Argon2iPasswordEncoderTest::testValidationWithConfig password_hash(): Memory cost is outside of allowed memory range /home/gadelat/PhpstormProjects/symfony/src/Symfony/Component/Security/Core/Encoder/Argon2iPasswordEncoder.php:105 /home/gadelat/PhpstormProjects/symfony/src/Symfony/Component/Security/Core/Encoder/Argon2iPasswordEncoder.php:67 /home/gadelat/PhpstormProjects/symfony/src/Symfony/Component/Security/Core/Tests/Encoder/Argon2iPasswordEncoderTest.php:34 ```
|
Can confirm, the same error was happening to me locally. The error is really odd though. |
chalasr
approved these changes
May 25, 2018
ogizanagi
approved these changes
May 25, 2018
|
Thank you @ostrolucky. |
nicolas-grekas
added a commit
that referenced
this pull request
May 25, 2018
This PR was merged into the 4.1 branch. Discussion ---------- Tweak Argon2 test config | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Memory cost 8 seems to be lowest value accepted on my machine ``` Testing Symfony\Component\Security\Core\Tests\Encoder\Argon2iPasswordEncoderTest E.... 5 / 5 (100%) Time: 114 ms, Memory: 4.00MB There was 1 error: 1) Symfony\Component\Security\Core\Tests\Encoder\Argon2iPasswordEncoderTest::testValidationWithConfig password_hash(): Memory cost is outside of allowed memory range /home/gadelat/PhpstormProjects/symfony/src/Symfony/Component/Security/Core/Encoder/Argon2iPasswordEncoder.php:105 /home/gadelat/PhpstormProjects/symfony/src/Symfony/Component/Security/Core/Encoder/Argon2iPasswordEncoder.php:67 /home/gadelat/PhpstormProjects/symfony/src/Symfony/Component/Security/Core/Tests/Encoder/Argon2iPasswordEncoderTest.php:34 ``` Commits ------- 0e74f73 Tweak Argon2 test config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory cost 8 seems to be lowest value accepted on my machine