[Form] fix tests on old phpunit versions #27338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5bd5ad to
162dabe
Compare
162dabe to
208d1d1
Compare
nicolas-grekas
added a commit
that referenced
this pull request
May 22, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [Form] fix tests on old phpunit versions | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Should make appveyor green. Commits ------- 208d1d1 [Form] fix tests on old phpunit versions
stof
reviewed
May 22, 2018
| @@ -60,5 +60,5 @@ public function getMaxDepth(); | |||
| /** | |||
| * Merges an {@see AttributeMetadataInterface} with in the current one. | |||
| */ | |||
| public function merge(self $attributeMetadata); | |||
| public function merge(AttributeMetadataInterface $attributeMetadata); | |||
There was a problem hiding this comment.
the issue with this change is that PHP-CS-Fixer will revert it on any run.
There was a problem hiding this comment.
true, but we look at tests before merging, don't we? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make appveyor green.