8000 Fix tests in ArgumentMetadataFactoryTest by upyx · Pull Request #27274 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fix tests in ArgumentMetadataFactoryTest #27274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix tests in ArgumentMetadataFactoryTest #27274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix tests in ArgumentMetadataFactoryTest
  • Loading branch information
@upyx
upyx committed May 15, 2018
commit 3dabae1c553ce616e25be93ece8ad928a54e0210
7 changes: 4 additions & 3 deletions src/Symfony/Component/HttpKernel/Tests/ControllerMetadata/ArgumentMetadataFactoryTest.php
View file
Open in desktop
A5E1
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,10 @@ public function testSignature1()
$arguments = $this->factory->createArgumentMetadata(array($this, 'signature1'));

$this->assertEquals(array(
new ArgumentMetadata('foo', self::class, false, false, null),
new ArgumentMetadata('foo', 'self', false, false, null),
new ArgumentMetadata('bar', 'array', false, false, null),
new ArgumentMetadata('baz', 'callable', false, false, null),
new ArgumentMetadata('quux', TestCase::class, false, false, null),
), $arguments);
}

Expand All @@ -47,7 +48,7 @@ public function testSignature2()
$arguments = $this->factory->createArgumentMetadata(array($this, 'signature2'));

$this->assertEquals(array(
new ArgumentMetadata('foo', self::class, false, true, null, true),
new ArgumentMetadata('foo', 'self', false, true, null, true),
new ArgumentMetadata('bar', __NAMESPACE__.'\FakeClassThatDoesNotExist', false, true, null, true),
new ArgumentMetadata('baz', 'Fake\ImportedAndFake', false, true, null, true),
), $arguments);
Expand Down Expand Up @@ -117,7 +118,7 @@ public function testNullableTypesSignature()
), $arguments);
}

private function signature1(self $foo, array $bar, callable $baz)
private function signature1(self $foo, array $bar, callable $baz, TestCase $quux)
{
}

Expand Down
0