8000 [Messenger] Remove autoconfiguration for Sender/ReceiverInterface by kbond · Pull Request #27228 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Messenger] Remove autoconfiguration for Sender/ReceiverInterface #27228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2018
Merged

[Messenger] Remove autoconfiguration for Sender/ReceiverInterface #27228

merged 1 commit into from
May 11, 2018

Conversation

kbond
Copy link
Member
@kbond kbond commented May 10, 2018
Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

When creating a custom transport I ran into an error where the container was trying to autowire my transport and failing because it has arguments that can't be autowired.

The Transport service is created by the TransportFactory so this is not needed. (unless I am missing something)

@sroze
Copy link
Contributor
sroze commented May 11, 2018

Yep, makes sense as we introduced TransportInterface. You need to rebase though.

@kbond
Copy link
Member Author
kbond commented May 11, 2018

Rebased.

@sroze
Copy link
Contributor
sroze commented May 11, 2018

Thank you @kbond.

@sroze sroze merged commit fa4ce7b into symfony:4.1 May 11, 2018
sroze added a commit that referenced this pull request May 11, 2018
…terface (kbond)

This PR was merged into the 4.1 branch.

Discussion
----------

[Messenger] Remove autoconfiguration for Sender/ReceiverInterface

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

When creating a custom transport I ran into an error where the container was trying to autowire my transport and failing because it has arguments that can't be autowired.

The Transport service is created by the TransportFactory so this is not needed. (unless I am missing something)

Commits
-------

fa4ce7b [Messenger] remove autoconfiguration for Sender/ReceiverInterface
@kbond kbond deleted the messenger/remove-autoconfiguration branch May 11, 2018 13:18
@fabpot fabpot mentioned this pull request May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0