[Messenger] Remove autoconfiguration for Sender/ReceiverInterface #27228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, makes sense as we introduced |
|
Rebased. |
ogizanagi
approved these changes
May 11, 2018
sroze
approved these changes
May 11, 2018
|
Thank you @kbond. |
sroze
added a commit
that referenced
this pull request
May 11, 2018
…terface (kbond) This PR was merged into the 4.1 branch. Discussion ---------- [Messenger] Remove autoconfiguration for Sender/ReceiverInterface | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a When creating a custom transport I ran into an error where the container was trying to autowire my transport and failing because it has arguments that can't be autowired. The Transport service is created by the TransportFactory so this is not needed. (unless I am missing something) Commits ------- fa4ce7b [Messenger] remove autoconfiguration for Sender/ReceiverInterface
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a custom transport I ran into an error where the container was trying to autowire my transport and failing because it has arguments that can't be autowired.
The Transport service is created by the TransportFactory so this is not needed. (unless I am missing something)