Improve github issue templates #27193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3eceda9 to
39e5b16
Compare
|
So is "Security" for the Security component? I know the answer, but I'm afraid that someone that thinks "Oh a bug in the security configuration", might follow that link instead. |
xabbuh
approved these changes
May 8, 2018
Oliboy50
approved these changes
May 8, 2018
ogizanagi
approved these changes
May 8, 2018
lyrixx
approved these changes
May 8, 2018
fabpot
requested changes
May 9, 2018
| @@ -1,9 +1,11 @@ | |||
| --- | |||
| name: Security Issue | |||
| about: Report security-related errors | |||
There was a problem hiding this comment.
I would keep the current description and add the URL after in parenthesis.
|
@fabpot updated. Status: needs review |
39e5b16 to
ffe5a32
Compare
fabpot
requested changes
May 11, 2018
| name: Support Question | ||
| about: Questions about using Symfony and its components | ||
| name: ⛔ Support Question | ||
| about: See https://symfony.com/support for questions about using Symfony and its components. |
There was a problem hiding this comment.
If you add a dot here, you should add it on other about section as well... or just remove the ones you added.
There was a problem hiding this comment.
TBH, I would have removed the ones you added
ffe5a32 to
5f7efd2
Compare
5f7efd2 to
a05ae9b
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
May 11, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- Improve github issue templates | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Fixes ordering and adds some visual hints:  Commits ------- a05ae9b Improve github issue templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ordering and adds some visual hints: