[Messenger] Add TransportInterface as first class citizen sender+receiver #27164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
887d7b4 to
bd0733d
Compare
sroze
reviewed
May 5, 2018
| @@ -33,7 +33,7 @@ public function __construct(EncoderInterface $messageEncoder, Connection $connec | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function send($message) | |||
| public function send($message): void | |||
There was a problem hiding this comment.
I’m not fond of the idea of enforcing void as a result. Senders might return something later on, we shouldn’t close that door IMHO.
There was a problem hiding this comment.
Removing void should be ok for the bc policy. See symfony/symfony-docs#9717
yceruto
reviewed
May 5, 2018
| */ | ||
| public function receive(callable $handler): void | ||
| { | ||
| ($this->receiver ?? $this->getReceiver())->receive($hander); |
There was a problem hiding this comment.
It seems ternary operator fits better here (same below) ?
There was a problem hiding this comment.
Not sure what you mean, doesn't feel like to me :)
There was a problem hiding this comment.
I think @yceruto mean next variant:
$this->receiver ? $this->receiver->receive($hander) ? $this->getReceiver()->receive($hander)There was a problem hiding this comment.
I meant ($this->receiver ?: $this->getReceiver())-> instead, as $this->receiver is always defined I don't see the need for ??, but probably I'm missing something here :)
There was a problem hiding this comment.
$this->receiver is null until $this->getReceiver() is called a first time. So makes sense to use the null-coalescing operator rather than ternary for this :)
There was a problem hiding this comment.
According to the manual:
The null coalescing operator (??) has been added as syntactic sugar for the common case of needing to use a ternary in conjunction with isset(). It returns its first operand if IT EXISTS and is not NULL; otherwise it returns its second operand.
So ternary operator fits better in this case as $this->receiver always exists (i.e. this var is defined always), but NVM it's just a detail, ?? works fine too.
|
This one should be rebased |
bd0733d to
e3f800f
Compare
e3f800f to
379b8eb
Compare
|
PR rebased |
ogizanagi
approved these changes
May 7, 2018
sroze
approved these changes
May 8, 2018
|
Thank you @nicolas-grekas. |
sroze
added a commit
that referenced
this pull request
May 8, 2018
…n sender+receiver (nicolas-grekas) This PR was merged into the 4.1 branch. Discussion ---------- [Messenger] Add TransportInterface as first class citizen sender+receiver | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The current design misses an opportunity to reuse the same connection for the sender and the receiver parts of a transport. By making `TransportInterface` a first class citizen, we simplify the wiring logic, we allow sharing the same connection for both the sender and the receiver, and we provide a natural point to lazily create the connection. Live from Las Vegas :)  Commits ------- 379b8eb [Messenger] Add TransportInterface as first class citizen sender+receiver
2 tasks
sroze
added a commit
that referenced
this pull request
May 8, 2018
This PR was merged into the 4.1 branch. Discussion ---------- [Messenger] Fix AMQP Transport | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27164 | License | MIT | Doc PR | - - [x] Fix typo - [x] Fix create `Connection` instance - [ ] Add test Commits ------- b8a4d5a Fix AmqpTransport
sroze
added a commit
that referenced
this pull request
May 8, 2018
…nterface (ogizanagi) This PR was merged into the 4.1 branch. Discussion ---------- [Messenger] Fix AMQP Transport factory & TransportFactoryInterface | Q | A | ------------- | --- | Branch? | 4.1 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #27164 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Seems like we did review a bit fast here 😅 Commits ------- 98967cd [Messenger] Fix AMQP Transport factory & TransportFactoryInterface
sroze
added a commit
that referenced
this pull request
May 8, 2018
This PR was merged into the 4.1 branch. Discussion ---------- [Messenger] Fix the transport factory after moving it | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27164 | License | MIT | Doc PR | ø `ChainTransportFactory` was renamed but the `messenger.xml` wasn't changed. Commits ------- 7a091d9 Fix the transport factory after moving it
6 tasks
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
May 9, 2018
This PR was submitted for the master branch but it was squashed and merged into the 4.1 branch instead (closes #9727). Discussion ---------- [Messenger] Update the messenger documentation - [x] Fixes #9641 with the middleware configuration. - [x] Fixes #9617 with the multiple bus configuration. - [x] Change adapters to transports (waiting merge: symfony/symfony#27129) - [x] middlewares config entry is renamed middleware (symfony/symfony#27177) - [x] in the config, message buses names are the full service id you'll use (symfony/symfony#27162) - [x] Add TransportInterface as first class citizen sender+receiver (symfony/symfony#27164) Commits ------- c3c3528 Few updates following review 64bfd75 Change wording and don't use `.`-based services so it's just clearer e1f3b5a Fix the formating of the method name 9b7b85f Update the example of using multiple buses to use DI's `bind`s c76b2c2 Uses the full service name when configuring the buses from the YAML configuration 2409798 Middleware does not have a plural a20286d Add a note about the symfony serializer pack 10f46eb Introduce the `TransportInterface` ef70bc0 Add a documentation about the middlewares 3ff8cfe Add multiple buses configuration and type-hint example a4bc592 Rename the adapters to transport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current design misses an opportunity to reuse the same connection for the sender and the receiver parts of a transport. By making
TransportInterfacea first class citizen, we simplify the wiring logic, we allow sharing the same connection for both the sender and the receiver, and we provide a natural point to lazily create the connection.Live from Las Vegas :)