[Serializer] Cache the normalizer to use when possible

symfony · nicolas-grekas · Apr 29, 2018 · Apr 25, 2018 · Apr 27, 2018 · Apr 27, 2018
commit c1e850fe834e01d32bbfab42cc5276b75422bdea
diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
@@ -30,7 +30,7 @@
  *
  * @author Kévin Dunglas <dunglas@gmail.com>
  */
-abstract class AbstractObjectNormalizer extends AbstractNormalizer
+abstract class AbstractObjectNormalizer extends AbstractNormalizer implements NormalizerWithCacheableSupportResultInterface
 {
     const ENABLE_MAX_DEPTH = 'enable_max_depth';
     const DEPTH_KEY_PATTERN = 'depth_%s::%s';

diff --git a/src/Symfony/Component/Serializer/Normalizer/ConstraintViolationListNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/ConstraintViolationListNormalizer.php
@@ -22,7 +22,7 @@
  * @author Grégoire Pineau <lyrixx@lyrixx.info>
  * @author Kévin Dunglas <dunglas@gmail.com>
  */
-class ConstraintViolationListNormalizer implements NormalizerInterface
+class ConstraintViolationListNormalizer implements NormalizerInterface, NormalizerWithCacheableSupportResultInterface
 {
     /**
      * {@inheritdoc}

diff --git a/src/Symfony/Component/Serializer/Normalizer/CustomNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/CustomNormalizer.php
@@ -17,7 +17,7 @@
 /**
  * @author Jordi Boggiano <j.boggiano@seld.be>
  */
-class CustomNormalizer implements NormalizerInterface, DenormalizerInterface, SerializerAwareInterface
+class CustomNormalizer implements NormalizerInterface, DenormalizerInterface, SerializerAwareInterface, NormalizerWithCacheableSupportResultInterface
 {
     use ObjectToPopulateTrait;
     use SerializerAwareTrait;

diff --git a/src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php
@@ -23,7 +23,7 @@
  *
  * @author Kévin Dunglas <dunglas@gmail.com>
  */
-class DataUriNormalizer implements NormalizerInterface, DenormalizerInterface
+class DataUriNormalizer implements NormalizerInterface, DenormalizerInterface, NormalizerWithCacheableSupportResultInterface
 {
     private static $supportedTypes = array(
         \SplFileInfo::class => true,

diff --git a/src/Symfony/Component/Serializer/Normalizer/DateIntervalNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/DateIntervalNormalizer.php
@@ -20,7 +20,7 @@
  *
  * @author Jérôme Parmentier <jerome@prmntr.me>
  */
-class DateIntervalNormalizer implements NormalizerInterface, DenormalizerInterface
+class DateIntervalNormalizer implements NormalizerInterface, DenormalizerInterface, NormalizerWithCacheableSupportResultInterface
 {
     const FORMAT_KEY = 'dateinterval_format';
 

diff --git a/src/Symfony/Component/Serializer/Normalizer/DateTimeNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/DateTimeNormalizer.php
@@ -20,7 +20,7 @@
  *
  * @author Kévin Dunglas <dunglas@gmail.com>
  */
-class DateTimeNormalizer implements NormalizerInterface, DenormalizerInterface
+class DateTimeNormalizer implements NormalizerInterface, DenormalizerInterface, NormalizerWithCacheableSupportResultInterface
 {
     const FORMAT_KEY = 'datetime_format';
     const TIMEZONE_KEY = 'datetime_timezone';

diff --git a/src/Symfony/Component/Serializer/Normalizer/JsonSerializableNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/JsonSerializableNormalizer.php
@@ -19,7 +19,7 @@
  *
  * @author Fred Cox <mcfedr@gmail.com>
  */
-class JsonSerializableNormalizer extends AbstractNormalizer
+class JsonSerializableNormalizer extends AbstractNormalizer implements NormalizerWithCacheableSupportResultInterface
 {
     /**
      * {@inheritdoc}

diff --git a/...Symfony/Component/Serializer/Normalizer/NormalizerWithCacheableSupportResultInterface.php b/...Symfony/Component/Serializer/Normalizer/NormalizerWithCacheableSupportResultInterface.php
@@ -0,0 +1,21 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Serializer\Normalizer;
+
+/**
+ * "supportsNormalization()" methods of normalizers implementing this interface have a cacheable return.
+ *
+ * @author Kévin Dunglas <dunglas@gmail.com>
+ */
+interface NormalizerWithCacheableSupportResultInterface
+{
+}
diff --git a/src/Symfony/Component/Serializer/Serializer.php b/src/Symfony/Component/Serializer/Serializer.php
@@ -26,6 +26,7 @@
 use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
 use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;
 use Symfony\Component\Serializer\Exception\LogicException;
+use Symfony\Component\Serializer\Normalizer\NormalizerWithCacheableSupportResultInterface;
 
 /**
  * Serializer serializes and deserializes data.
@@ -54,6 +55,8 @@ class Serializer implements SerializerInterface, ContextAwareNormalizerInterface
      */
     protected $decoder;
 
+    private $normalizerCache = array();
+
     /**
      * @var array
      */
@@ -202,11 +205,34 @@ public function supportsDenormalization($data, $type, $format = null, array $con
      */
     private function getNormalizer($data, $format, array $context)
     {
+        $type = \is_object($data) ? 'c-'.\get_class($data) : \gettype($data);
+        if (
+            isset($this->normalizerCache[$type][$format]) ||
+            (isset($this->normalizerCache[$type]) && \array_key_exists($format, $this->normalizerCache[$type]))
+        ) {
+            return $this->normalizerCache[$type][$format];
+        }
+
+        $cacheable = true;
         foreach ($this->normalizers as $normalizer) {
-            if ($normalizer instanceof NormalizerInterface && $normalizer->supportsNormalization($data, $format, $context)) {
+            if (!$normalizer instanceof NormalizerInterface) {
+                continue;
+            }
+
+            $cacheable = $cacheable && $normalizer instanceof NormalizerWithCacheableSupportResultInterface;
+            if ($normalizer->supportsNormalization($data, $format, $context)) {
+                if ($cacheable) {
+                    $this->normalizerCache[$type][$format] = $normalizer;
+                }
+
                 return $normalizer;
             }
         }
+
+        if ($cacheable) {
+            // allow to cache primitive types
+            $this->normalizerCache[$type][$format] = null;
+        }
     }
 
     /**