[FrameworkBundle] Register all private services on the test service container #27048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb8f93c to
28f1337
Compare
…ontainer Before this fix, only services explicitly configured with public=false were exposed via the test service container: ``` $container->register(PrivateService::class, PrivateService::class)->setPublic(false); ``` but not those explicitly configured as private: ``` $container->register(PrivateService::class, PrivateService::class)->setPrivate(true); ``` nor those implicitly configured as private: ``` $container->register(PrivateService::class, PrivateService::class); ```
28f1337 to
6677393
Compare
nicolas-grekas
approved these changes
Apr 25, 2018
|
Thank you @jakzal. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 25, 2018
…t service container (jakzal) This PR was merged into the 4.1-dev branch. Discussion ---------- [FrameworkBundle] Register all private services on the test service container | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Before this fix, only services explicitly configured with public=false were exposed via the test service container: ```php $container->register(PrivateService::class, PrivateService::class)->setPublic(false); ``` but not those explicitly configured as private: ```php $container->register(PrivateService::class, PrivateService::class)->setPrivate(true); ``` nor those implicitly configured as private: ```php $container->register(PrivateService::class, PrivateService::class); ``` Commits ------- 6677393 [FrameworkBundle] Register all private services on the test service container
|
Very good, thanks @jakzal 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, only services explicitly configured with public=false were exposed via the test service container:
but not those explicitly configured as private:
nor those implicitly configured as private: