8000 [Form] Add time zone translations by c960657 · Pull Request #26851 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Add time zone translations #26851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Form] Add time zone translations #26851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dca6a05
Add time zone translations
c960657 Apr 4, 2018
1b75db4
Mark as @internal
c960657 Apr 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Symfony/Component/Form/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ CHANGELOG

* added `input=datetime_immutable` to DateType, TimeType, DateTimeType
* added `rounding_mode` option to MoneyType
* added translations for TimezoneType

4.0.0
-----
Expand Down
8 changes: 5 additions & 3 deletions src/Symfony/Component/Form/Extension/Core/Type/TimezoneType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public function configureOptions(OptionsResolver $resolver)
return self::getTimezones($regions);
});
},
'choice_translation_domain' => false,
'choice_translation_domain' => 'timezone',
'input' => 'string',
'regions' => \DateTimeZone::ALL,
));
Expand Down Expand Up @@ -71,8 +71,10 @@ public function getBlockPrefix()

/**
* Returns a normalized array of timezone choices.
*
* @internal This should only be called from update-timezone-translations.php.
*/
private static function getTimezones(int $regions): array
public static function getTimezones(int $regions): array
{
$timezones = array();

Expand All @@ -81,7 +83,7 @@ private static function getTimezones(int $regions): array

if (count($parts) > 2) {
$region = $parts[0];
$name = $parts[1].' - '.$parts[2];
$name = $parts[2].', '.$parts[1];
} elseif (count($parts) > 1) {
$region = $parts[0];
$name = $parts[1];
Expand Down
164 changes: 164 additions & 0 deletions src/Symfony/Component/Form/Resources/bin/update-timezone-translations.php
View file
Open in desktop
D042
Original file line number Diff line number Diff line change
@@ -0,0 +1,164 @@
#!/usr/bin/env php
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

/**
* Generates translation files for use in TimezoneType based on the Unicode
* Common Locale Data Repository.
*
* The generates files are written to Resources/translations and should be
* committed to Git.
*/
$componentDir = realpath(__DIR__.'/../..');
$autoloadFile = $componentDir.'/vendor/autoload.php';

if (!is_file($autoloadFile)) {
die("$autoloadFile not found; run `composer update` in $componentDir.\n");
}

require_once $autoloadFile;

use Symfony\Component\Form\Extension\Core\Type\TimezoneType;
use Symfony\Component\Translation\Dumper\XliffFileDumper;
use Symfony\Component\Translation\MessageCatalogue;

// We only support a small subset of the many locales included in CLDR.
$locales = array(
'ar' => 'ar',
'az' => 'az',
'bg' => 'bg',
'ca' => 'ca',
'cs' => 'cs',
'da' => 'da',
'de' => 'de',
'el' => 'el',
'en' => 'en',
'es' => 'es',
'et' => 'et',
'eu' => 'eu',
'fa' => 'fa',
'fi' => 'fi',
'fr' => 'fr',
'gl' => 'gl',
'he' => 'he',
'hr' => 'hr',
'hu' => 'hu',
'hy' => 'hy',
'id' => 'id',
'it' => 'it',
'ja' => 'ja',
'lb' => 'lb',
'lt' => 'lt',
'lv' => 'lv',
'mn' => 'mn',
'nb' => 'nb',
'nl' => 'nl',
'nn' => 'nn',
'no' => 'no',
'pl' => 'pl',
'pt' => 'pt',
'pt_BR' => 'pt_BR',
'ro' => 'ro',
'ru' => 'ru',
'sk' => 'sk',
'sl' => 'sl',
'sr_Cyrl' => 'sr',
'sr_Latn' => 'sr_Latn',
'sv' => 'sv',
'tl' => 'tl',
'uk' => 'uk',
'zh_CN' => 'zh_Hans_CN',
);

// Timezone identifiers containing 2 slashes need a qualifier in addition to
// just the city name. E.g. America/Argentina/San_Juan needs to be distinguished
// from other cities named San Juan. On the other hand, for US states the CLDR
// string already contains the qualifier, e.g. the English string fo
// America/Indiana/Knox is "Knox, Indiana".
$countries = array(
'America/Argentina' => 'AR',
'America/Indiana' => false,
'America/Kentucky' => false,
'America/North_Dakota' => false,
);

// Not all tzdata areas (the string before the first slash) correspond to
// territories definded in CLDR.
$areas = array(
'America' => '019',
'Africa' => '002',
'Antarctica' => 'AQ',
'Arctic' => false,
'Asia' => '142',
'Atlantic' => false,
'Australia' => '053',
'Europe' => '150',
'Indian' => false,
'Pacific' => false,
'Other' => false,
);

$options = array(
'path' => $componentDir.'/Resources/translations/generated',
'default_locale' => 'en',
'tool_info' => array(
'tool-id' => basename(__FILE__),
'tool-name' => 'CLDR time zone translation generator',
),
);

$timezones = TimezoneType::getTimezones(\DateTimeZone::ALL);

$domain = 'timezones';

$identifiers = \DateTimeZone::listIdentifiers(\DateTimeZone::ALL_WITH_BC);

foreach ($locales as $locale => $cldrLocale) {
$names = array();

foreach ($timezones as $area => $identifiers) {
if (!isset($areas[$area])) {
die("Area $area not \$areas.\n");
}
if ($areas[$area]) {
$areaName = Punic\Territory::getName($areas[$area], $cldrLocale);
if ($areaName) {
$names[$area] = $areaName;
}
}

foreach ($identifiers as $key => $identifier) {
$timezoneName = Punic\Calendar::getTimezoneExemplarCity($identifier, false, $cldrLocale);

$parts = explode('/', $identifier);
if (count($parts) >= 3) {
$prefix = $parts[0].'/'.$parts[1];
if (!isset($countries[$prefix])) {
die("Prefix $prefix not defined in \$countries.\n");
}
if ($countries[$prefix]) {
$countryName = Punic\Territory::getName($countries[$prefix], $cldrLocale);
$timezoneName .= ', '.$countryName;
}
}

if ($timezoneName) {
$names[$key] = $timezoneName;
}
}
}

$catalogue = new MessageCatalogue($locale);
$catalogue->add($names, $domain);

$dumper = new XliffFileDumper();
$dumper->dump($catalogue, $options);
}
Loading
0