8000 [WebProfilerBundle][HttpKernel] Make FileLinkFormatter URL format generation lazy by nicolas-grekas · Pull Request #26758 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[WebProfilerBundle][HttpKernel] Make FileLinkFormatter URL format generation lazy #26758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2018
Merged

[WebProfilerBundle][HttpKernel] Make FileLinkFormatter URL format generation lazy #26758

merged 1 commit into from
Apr 3, 2018

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #26755, #26754
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Apr 3, 2018
@nicolas-grekas nicolas-grekas mentioned this pull request Apr 3, 2018
Merged
@fabpot fabpot mentioned this pull request Apr 3, 2018
Closed
@fabpot
Copy link
Member
fabpot commented Apr 3, 2018

Thank you @nicolas-grekas.

@fabpot fabpot merged commit e074c05 into symfony:3.4 Apr 3, 2018
fabpot added a commit that referenced this pull request Apr 3, 2018
@fabpot
bug #26758 [WebProfilerBundle][HttpKernel] Make FileLinkFormatter URL…
341682e 
… format generation lazy (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[WebProfilerBundle][HttpKernel] Make FileLinkFormatter URL format generation lazy

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #26755, #26754
| License       | MIT
| Doc PR        | -

Commits
-------

e074c05 [WebProfilerBundle][HttpKernel] Make FileLinkFormatter URL format generation lazy
@nicolas-grekas nicolas-grekas mentioned this pull request Apr 3, 2018
Closed
mattagohni pushed a commit to solutionDrive/SyliusProductBundlesPlugin that referenced this pull request Apr 3, 2018
added conflict to current symfony version and above untill issue symf…
91f4b44 
…ony/symfony#26758 is released.
@tomtomau
Copy link
Contributor
tomtomau commented Apr 4, 2018

Will we have to wait around a month to get this fix in either 4.1 or 4.0.8? Was waiting for #26568 in 4.0.7 but then this broke my functional tests. So just trying to work out whether to fork and apply this patch or just wait.

Cheers!

This was referenced Apr 4, 2018
Closed
Closed
stof
stof reviewed Apr 4, 2018
View reviewed changes
src/Symfony/Bundle/WebProfilerBundle/DependencyInjection/WebProfilerExtension.php
@@ -53,6 +56,11 @@ public function load(array $configs, ContainerBuilder $container)
$container->setParameter('web_profiler.debug_toolbar.intercept_redirects', $config['intercept_redirects']);
$container->setParameter('web_profiler.debug_toolbar.mode', $config['toolbar'] ? WebDebugToolbarListener::ENABLED : WebDebugToolbarListener::DISABLED);
}

if (Kernel::VERSION_ID >= 30408 || Kernel::VERSION_ID >= 40008) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be Kernel::VERSION_ID >= 30408 && Kernel::VERSION_ID < 40000 || Kernel::VERSION_ID >= 40008)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 946eefa

@nicolas-grekas nicolas-grekas deleted the fix-file-link branch April 4, 2018 12:13
@phansys phansys mentioned this pull request Apr 4, 2018
Closed
@xabbuh xabbuh mentioned this pull request Apr 4, 2018
Closed
@dmaicher dmaicher mentioned this pull request Apr 4, 2018
Closed
@enumag
Copy link
Contributor
enumag commented Apr 5, 2018

Can someone tell my why is WebProfilerBundle active in test env? What is it used for in tests?

@tomtomau
Copy link
Contributor
tomtomau commented Apr 5, 2018 via email

@andrerom
Copy link
Contributor
andrerom commented Apr 5, 2018

@nicolas-grekas Any chance of getting this out soon? Having the following kind of errors reported with what I presume is this issue:

In Container.php line 297:
                                                                               
  Circular reference detected for service "routing.loader", path: "routing.lo  
  ader".

This was referenced Apr 6, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@fabpot fabpot fabpot approved these changes

@ogizanagi ogizanagi ogizanagi approved these changes

Assignees
No one assigned
Labels
Bug HttpKernel Status: Reviewed WebProfilerBundle
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
8 participants
@nicolas-grekas @fabpot @tomtomau @enumag @andrerom @stof @ogizanagi @carsonbot
0