Updated the Messenger profiler panel #26674
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| {% extends '@WebProfiler/Profiler/layout.html.twig' %} | ||
|
|
||
| {% import _self as helper %} | ||
|
|
||
| {% block toolbar %} | ||
| {% set color_code = 'normal' %} | ||
| {% set message_count = 0 %} | ||
| {% set icon %} | ||
| {{ include('@WebProfiler/Icon/messenger.svg') }} | ||
| <span class="sf-toolbar-value">{{ message_count }}</span> | ||
| {% endset %} | ||
|
|
||
| {{ include('@WebProfiler/Profiler/toolbar_item.html.twig', { link: 'messages', status: color_code }) }} | ||
|
There was a problem hiding this comment. you could even avoid passing the status explicitly, as you never change it to anything else than |
||
| {% endblock %} | ||
|
|
||
| {% block menu %} | ||
| <span class="label"> | ||
| <span class="icon">{{ include('@WebProfiler/Icon/messenger.svg') }}</span> | ||
| <strong>Messages</strong> | ||
|
|
||
| {% if collector.messages|length > 0 %} | ||
|
There was a problem hiding this comment. IIRC, we removed all counts from the profiler menu in the redesign done in 2.8. Why having it here ? There was a problem hiding this comment. True ... but I've moved this to There was a problem hiding this comment. Well, you haven't removed the count itself in the profiler menu |
||
| <span class="count"> | ||
| <span>{{ collector.messages|length }}</span> | ||
| </span> | ||
| {% endif %} | ||
| </span> | ||
| {% endblock %} | ||
|
|
||
| {% block panel %} | ||
| <h2>Messages</h2> | ||
|
|
||
| {% if collector.messages is empty %} | ||
| <div class="empty"> | ||
| <p>No messages have been collected.</p> | ||
| </div> | ||
| {% else %} | ||
| <table> | ||
| <thead> | ||
| <tr> | ||
| <th>Message</th> | ||
| <th>Result</th> | ||
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| {% for message in collector.messages %} | ||
| <tr> | ||
| <td>{{ message.message.type }}</td> | ||
| <td> | ||
| {% if message.result.type is defined %} | ||
| {{ message.result.type }} | ||
| {% endif %} | ||
|
|
||
| {% if message.exception.type is defined %} | ||
| {{ message.exception.type }} | ||
| {% endif %} | ||
| </td> | ||
| </tr> | ||
| {% endfor %} | ||
| </tbody> | ||
| </table> | ||
| {% endif %} | ||
| {% endblock %} | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong count here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be fixed in #26650
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed