[Console] Fix docblock of DescriptorInterface::describe #26604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Mar 19, 2018
|
@codedmonkey for your next PR, please keep the full PR template. |
fabpot
approved these changes
Mar 19, 2018
|
Thank you @codedmonkey. |
fabpot
added a commit
that referenced
this pull request
Mar 19, 2018
…(codedmonkey) This PR was merged into the 2.7 branch. Discussion ---------- [Console] Fix docblock of DescriptorInterface::describe | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes? This might be the smallest commit ever, but I came across this docblock which seems to be incorrectly copied from https://github.com/symfony/symfony/blob/7101893b51cf6d6e2a9bc131eadefa0a02151d11/src/Symfony/Component/Console/Descriptor/Descriptor.php#L74 and it threw me off guard for a moment when I read it. I can see more improvements being made (like mentioning the `InvalidArgumentException`) but I didn't want to overdo it. Commits ------- dad27b0 [Console] Fix docblock of DescriptorInterface::describe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be the smallest commit ever, but I came across this docblock which seems to be incorrectly copied from
symfony/src/Symfony/Component/Console/Descriptor/Descriptor.php
Line 74 in 7101893
I can see more improvements being made (like mentioning the
InvalidArgumentException) but I didn't want to overdo it.