8000 [TwigBridge] Make sure we always render errors. Eventhough labels are disabled by Nyholm · Pull Request #26591 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[TwigBridge] Make sure we always render errors. Eventhough labels are disabled #26591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2018
Merged

[TwigBridge] Make sure we always render errors. Eventhough labels are disabled #26591

merged 1 commit into from
Mar 18, 2018

Conversation

Nyholm
Copy link
Member
@Nyholm Nyholm commented Mar 18, 2018
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #26536
License MIT
Doc PR

If one use form type with 'label'=>false then no errors where visible. This PR make sure we always print errors.

@Nyholm Nyholm mentioned this pull request Mar 18, 2018
Closed
@fabpot
Copy link
Member
fabpot commented Mar 18, 2018

Thank you @Nyholm.

@fabpot fabpot merged commit d8f3de9 into symfony:3.4 Mar 18, 2018
fabpot added a commit that referenced this pull request Mar 18, 2018
@fabpot
bug #26591 [TwigBridge] Make sure we always render errors. Eventhough…
c59bbc5 
… labels are disabled (Nyholm)

This PR was merged into the 3.4 branch.

Discussion
----------

[TwigBridge] Make sure we always render errors. Eventhough labels are disabled

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #26536
| License       | MIT
| Doc PR        |

If one use form type with `'label'=>false` then no errors where visible. This PR make sure we always print errors.

Commits
-------

d8f3de9 Make sure we always render errors. Eventhough labels are disabled
@xabbuh xabbuh mentioned this pull request Mar 22, 2018
Closed
This was referenced Apr 3, 2018
Merged
Merged
@ro0NL ro0NL mentioned this pull request Apr 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed TwigBridge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nyholm @fabpot @javiereguiluz @carsonbot
0