8000 [Bridge\PhpUnit] Cannot autoload class "\Symfony\Bridge\PhpUnit\SymfonyTestsListener" by yakobe · Pull Request #26562 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Bridge\PhpUnit] Cannot autoload class "\Symfony\Bridge\PhpUnit\SymfonyTestsListener" #26562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2018
Merged

[Bridge\PhpUnit] Cannot autoload class "\Symfony\Bridge\PhpUnit\SymfonyTestsListener" #26562

merged 1 commit into from
Mar 19, 2018

Conversation

yakobe
Copy link
Contributor
@yakobe yakobe commented Mar 16, 2018 •
edited by nicolas-grekas
Loading
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #26430
License MIT
Doc PR -

Allows composer to discover the class for autoloading when using composer install --classmap-authoritative

@nicolas-grekas nicolas-grekas changed the title [Bridge\PhpUnit] Fix #26430 Cannot autoload class "\Symfony\Bridge\Ph… [Bridge\PhpUnit] Fix #26430 Cannot autoload class "\Symfony\Bridge\PhpUnit\SymfonyTestsListener" Mar 16, 2018
@nicolas-grekas nicolas-grekas changed the title [Bridge\PhpUnit] Fix #26430 Cannot autoload class "\Symfony\Bridge\PhpUnit\SymfonyTestsListener" [Bridge\PhpUnit] Cannot autoload class "\Symfony\Bridge\PhpUnit\SymfonyTestsListener" Mar 16, 2018
nicolas-grekas
nicolas-grekas requested changes Mar 16, 2018
View reviewed changes
src/Symfony/Bridge/PhpUnit/SymfonyTestsListener.php Outdated
@@ -18,3 +18,7 @@ class_alias('Symfony\Bridge\PhpUnit\Legacy\SymfonyTestsListenerForV6', 'Symfony\
} else {
class_alias('Symfony\Bridge\PhpUnit\Legacy\SymfonyTestsListenerForV7', 'Symfony\Bridge\PhpUnit\SymfonyTestsListener');
}

if (false){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space after closing bracket

src/Symfony/Bridge/PhpUnit/SymfonyTestsListener.php Outdated
@@ -18,3 +18,7 @@ class_alias('Symfony\Bridge\PhpUnit\Legacy\SymfonyTestsListenerForV6', 'Symfony\
} else {
class_alias('Symfony\Bridge\PhpUnit\Legacy\SymfonyTestsListenerForV7', 'Symfony\Bridge\PhpUnit\SymfonyTestsListener');
}

if (false){
class SymfonyTestsListener{}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please put {} on separate lines

class SymfonyTestsListener
{
}

@nicolas-grekas
Copy link
Member

CoverageListener also should get the same fix

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Mar 16, 2018
@yakobe
Copy link
Contributor Author
yakobe commented Mar 16, 2018

Updated

@yakobe
Copy link
Contributor Author
yakobe commented Mar 19, 2018

The build failed with appveyor, so i rebased with latest changes and built again. Now it fails with travis-ci. The fails have nothing to do with this change.
@nicolas-grekas are they just a bit fragile? Do i need to do anything else?

@nicolas-grekas
Copy link
Member

Thank you @yakobe.

@nicolas-grekas nicolas-grekas merged commit 6b6fdab into symfony:3.4 Mar 19, 2018
nicolas-grekas added a commit that referenced this pull request Mar 19, 2018
@nicolas-grekas
bug #26562 [Bridge\PhpUnit] Cannot autoload class "\Symfony\Bridge\Ph…
5d00aa3 
…pUnit\SymfonyTestsListener" (Jake Bishop)

This PR was merged into the 3.4 branch.

Discussion
----------

[Bridge\PhpUnit] Cannot autoload class "\Symfony\Bridge\PhpUnit\SymfonyTestsListener"

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #26430
| License       | MIT
| Doc PR        | - <!-- required for new features -->

Allows composer to discover the class for autoloading when using `composer install --classmap-authoritative`

Commits
-------

6b6fdab [Bridge\PhpUnit] Fix #26430 Cannot autoload listeners
@yakobe
Copy link
Contributor Author
yakobe commented Mar 19, 2018

Thank you @nicolas-grekas ! Now i can use it :)

This was referenced Apr 3, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Bug PhpUnitBridge Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@yakobe @nicolas-grekas @derrabus @carsonbot
0