[Security] Multiple comma-separated IP addresses in access_control rule #26560
Conversation
…d IP addresses into an array
81c2f6a to
7b14d79
Compare
|
But shouldn't you define an array of IPs in the XML instead of "hacking" a string to simulate an array with commas? |
|
@javiereguiluz can still be more convenient to write, and can be more natural to some (as suggested by the existence of this PR?) But would be a new feature then of course. |
|
Adding support for comma-separated IPs is also a new feature. |
|
@nicolas-grekas I never use XML, so maybe what I'm saying doesn't make sense. However, in other parts of Symfony, when you define multiple values in XML, you use an XML array, not a comma-separated string. So, I think the user should define this: <option name="ips">
<value>127.0.0.1</value>
<value>::1</value>
</option>instead of this: <option name="ips" value="127.0.0.1, ::1"></option> |
|
Closing for the reason given by @javiereguiluz as his reasoning look correct to me. |
This PR was merged into the 2.7 branch. Discussion ---------- fix some security config examples see also symfony/symfony#26560 Commits ------- e687e24 fix some security config examples
When using multiple comma-separated IP addresses in an access_control rule in XML they were used as one IP address.