8000 [DomCrawler] Change bad wording in ChoiceFormField::untick by dunglas · Pull Request #26548 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DomCrawler] Change bad wording in ChoiceFormField::untick #26548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2018
Merged

[DomCrawler] Change bad wording in ChoiceFormField::untick #26548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[DomCrawler] Change bad wording in ChoiceFormField::untick
  • Loading branch information
@dunglas
dunglas committed Mar 15, 2018
commit a4ec6d3c9c33ac4472615e049643a5bf882a3338
4 changes: 2 additions & 2 deletions src/Symfony/Component/DomCrawler/Field/ChoiceFormField.php
View file
Open in desktop
687D
Original file line number Diff line number Diff line change
Expand Up @@ -97,14 +97,14 @@ public function tick()
}

/**
* Ticks a checkbox.
* Unticks a checkbox.
*
* @throws \LogicException When the type provided is not correct
*/
public function untick()
{
if ('checkbox' !== $this->type) {
throw new \LogicException(sprintf('You cannot tick "%s" as it is not a checkbox (%s).', $this->name, $this->type));
throw new \LogicException(sprintf('You cannot untick "%s" as it is not a checkbox (%s).', $this->name, $this->type));
}

$this->setValue(false);
Expand Down
0