[FrameworkBundle] Respect debug mode when warm up annotations #26513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linaori
suggested changes
Mar 14, 2018
| */ | ||
| public function __construct(Reader $annotationReader, $phpArrayFile, CacheItemPoolInterface $fallbackPool, $excludeRegexp = null) | ||
| public function __construct(Reader $annotationReader, $phpArrayFile, CacheItemPoolInterface $fallbackPool, $excludeRegexp = null, $debug) |
There was a problem hiding this comment.
You've added a non-optional argument, which should have broken tests. If there are none, can you add one to prevent future regressions? As this argument is non-optional, it would also be a BC break. Can you make this argument optional with a default value to mimic the previous behavior?
There was a problem hiding this comment.
All done.
Added test for cache warmer for both cases - debug and no debug
Made argument optional
Make new argument for AnnotationsCacheWarmer::__construct optional to prevent BC break Add tests
nicolas-grekas
approved these changes
Mar 15, 2018
Extracted reader mock to method, made test compatible with old php-unit
|
Just pushed fix for old phpunit, but seems it was useless as changes already aproved (travis ran on old code) |
|
Still fails on PHP 5.5, missing "getMock()" |
tests compatibility with php 5.5
|
That's all, travis is happy now. |
nicolas-grekas
approved these changes
Mar 19, 2018
fabpot
approved these changes
Mar 19, 2018
|
Thank you @Strate. |
fabpot
added a commit
that referenced
this pull request
Mar 19, 2018
…ons (Strate) This PR was squashed before being merged into the 3.4 branch (closes #26513). Discussion ---------- [FrameworkBundle] Respect debug mode when warm up annotations | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Propagate current debug mode to the annotations reader. Without thi, warmup is useless with debug mode, because timetsamps are not written to cache. Commits ------- f3ec396 [FrameworkBundle] Respect debug mode when warm up annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate current debug mode to the annotations reader. Without thi, warmup is useless with debug mode, because timetsamps are not written to cache.