10000 [DomCrawler] FormField: remove a useless return statement by dunglas · Pull Request #26496 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DomCrawler] FormField: remove a useless return statement #26496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[DomCrawler] FormField: remove a useless return statement #26496

wants to merge 1 commit into from

Conversation

dunglas
Copy link
Member
@dunglas dunglas commented Mar 12, 2018 •
edited by nicolas-grekas
Loading
Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@dunglas dunglas changed the title [DomCrawler] FormField: remove an useless return statement [DomCrawler] FormField: remove a useless return statement Mar 12, 2018
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Mar 12, 2018
nicolas-grekas
nicolas-grekas approved these changes Mar 12, 2018
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for 3.4)

@fabpot
Copy link
Member
fabpot commented Mar 13, 2018

Good catch, thanks @dunglas.

fabpot added a commit that referenced this pull request Mar 13, 2018
@fabpot
minor #26496 [DomCrawler] FormField: remove a useless return statemen…
957588a 
…t (dunglas)

This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #26496).

Discussion
----------

[DomCrawler] FormField: remove a useless return statement

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | n/a

Commits
-------

6ca8b4b [DomCrawler] FormField: remove an useless return statement
@fabpot fabpot closed this Mar 13, 2018
@dunglas dunglas deleted the dom-crawler/useless-return branch March 13, 2018 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
DomCrawler Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@dunglas @fabpot @nicolas-grekas @carsonbot
0