8000 [DomCrawler] Improve the sprintf() call in selectButton() by dunglas · Pull Request #26490 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DomCrawler] Improve the sprintf() call in selectButton() #26490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[DomCrawler] Improve the sprintf() call in selectButton() #26490

wants to merge 2 commits into from

Conversation

dunglas
Copy link
Member
@dunglas dunglas commented Mar 11, 2018 •
edited
Loading
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Code cleanup and minor performance improvement. Similar to #26485.

javiereguiluz
javiereguiluz reviewed Mar 12, 2018
View reviewed changes
src/Symfony/Component/DomCrawler/Crawler.php Outdated

return $this->filterRelativeXPath($xpath);
return $this->filterRelativeXPath(
sprintf(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor comment: I think that our code policy requires that the sprintf() statement is in a single line, no matter how long it is (as done in #26485). Should we change this then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to agree to change this since it will be easier to read it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@javiereguiluz javiereguiluz added this to the 4.1 milestone Mar 12, 2018
nicolas-grekas
nicolas-grekas approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I suppose :) )

@nicolas-grekas
Copy link
Member

Thank you @dunglas.

nicolas-grekas added a commit that referenced this pull request Mar 16, 2018
@nicolas-grekas
minor #26490 [DomCrawler] Improve the sprintf() call in selectButton(…
e317879 
…) (dunglas)

This PR was squashed before being merged into the 4.1-dev branch (closes #26490).

Discussion
----------

[DomCrawler] Improve the sprintf() call in selectButton()

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  |no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? |no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | n/a

Code cleanup and minor performance improvement. Similar to #26485.

Commits
-------

a00cce6 [DomCrawler] Improve the sprintf() call in selectButton()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@Simperfit Simperfit Simperfit approved these changes

Assignees
No one assigned
Labels
DomCrawler Status: Reviewed
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
5 participants
@dunglas @nicolas-grekas @javiereguiluz @Simperfit @carsonbot
0